Implemented IPPool and IPreservations creation flow and static IPs set #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testisnullus
requested changes
Nov 23, 2023
controllers/clusters/on_premises.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| usedCIDRs := []string{} |
There was a problem hiding this comment.
Let's use var usedCIDRs []string
There was a problem hiding this comment.
Ok, will use
controllers/clusters/on_premises.go
Outdated
Comment on lines
324
to
338
| ipReservationsList := &apicalico.IPReservationList{} | ||
| err := k8sclient.List(ctx, ipReservationsList, &client.ListOptions{ | ||
| LabelSelector: labels.SelectorFromSet(map[string]string{ | ||
| models.ControlledByLabel: models.OperatorLabel, | ||
| }), | ||
| }) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| for _, reservation := range ipReservationsList.Items { | ||
| return reservation.Spec.ReservedCIDRs[0], nil | ||
| } | ||
|
|
||
| icIPPoolList := &apicalico.IPPoolList{} |
There was a problem hiding this comment.
Let's use ipReservationsList and ipPoolList variables or
icIPReservationsList and icIPPoolList, not both versions
There was a problem hiding this comment.
Ok, will remove ic prefix
controllers/clusters/on_premises.go
Outdated
| func getAvailablePrivateCIDR(unavailCIDRs []string) (string, error) { | ||
| for i := 0; i < 255; i++ { | ||
| checkNet := net.IPNet{ | ||
| IP: net.ParseIP(fmt.Sprintf("10.%d.0.0", i)), |
There was a problem hiding this comment.
Why do you use the second octet and mask 24? maybe we should use the third one here?
There was a problem hiding this comment.
Yeah, added third octet
RostislavPorohnya
force-pushed
the
onpremises-provisioning-reservations
branch
from
2a0bb5b
to
f31809a
Compare
testisnullus
requested changes
Nov 23, 2023
Comment on lines
+70
to
+71
| //+kubebuilder:rbac:groups=projectcalico.org,resources=ipreservations,verbs=get;list;watch;create;update;patch;delete;deletecollection | ||
| //+kubebuilder:rbac:groups=projectcalico.org,resources=ippools,verbs=get;list;watch;create;update;patch;delete;deletecollection |
There was a problem hiding this comment.
Let's add to another cluster's controllers, wdyt?
There was a problem hiding this comment.
These roles applied for manager so they work for all controllers
testisnullus
approved these changes
Nov 23, 2023
ribaraka
approved these changes
Nov 23, 2023
testisnullus
force-pushed
the
onpremises-provisioning
branch
4 times, most recently
from
9366fa1
to
9292b20
Compare
testisnullus
force-pushed
the
onpremises-provisioning
branch
3 times, most recently
from
0f36b70
to
d7fcad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.