Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label and indentation processors #1379

Merged
merged 26 commits into from
Jan 28, 2025
Merged

Fix label and indentation processors #1379

merged 26 commits into from
Jan 28, 2025

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Jan 22, 2025 •
edited
Loading

Pull Request

Fixes #1378 #1363

@edelarua edelarua added the sme label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Unit Tests Summary

    1 files     84 suites   1m 15s ⏱️
  876 tests   867 ✅   9 💤 0 ❌
1 882 runs  1 185 ✅ 697 💤 0 ❌

Results for commit a3a3a83.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
analyze_variables 👶 $+0.05$ analyze_vars_works_well_with_additional_stat_names_.stat_names_
analyze_variables 👶 $+0.24$ analyze_vars_works_well_with_additional_stat_names_.stat_names_and_stats_custom_fnc_
analyze_variables 💀 $0.05$ $-0.05$ analyze_vars_works_well_with_additional_stat_names_.stat_names_in_
analyze_variables 💀 $0.24$ $-0.24$ analyze_vars_works_well_with_additional_stat_names_.stat_names_in_and_stats_custom_fnc_

Results for commit 5897cb0

♻️ This comment has been updated with latest results.

@edelarua edelarua requested a review from Melkiades January 22, 2025 02:37
@edelarua edelarua marked this pull request as draft January 22, 2025 23:34
@edelarua edelarua linked an issue Jan 23, 2025 that may be closed by this pull request
Extend changes for factors/characters from get_labels to get_formats and get_indent #1363
Closed
@edelarua edelarua marked this pull request as ready for review January 24, 2025 04:34
@Melkiades Melkiades self-requested a review January 27, 2025 14:46
Melkiades
Melkiades reviewed Jan 27, 2025
View reviewed changes
R/count_values.R Outdated Show resolved Hide resolved
Melkiades
Melkiades reviewed Jan 27, 2025
View reviewed changes
R/count_occurrences.R Outdated Show resolved Hide resolved
Melkiades
Melkiades approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!! Great great job Emily. Thanks

@edelarua edelarua mentioned this pull request Jan 28, 2025
Open
@edelarua edelarua merged commit 0a17925 into main Jan 28, 2025
29 checks passed
@edelarua edelarua deleted the 1378_get_labels_indent branch January 28, 2025 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shajoezhu shajoezhu shajoezhu left review comments

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
3 participants
@edelarua @shajoezhu @Melkiades