-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation of lsmeans #413
Conversation
CLA Assistant Lite bot ✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's all right, I made just few comments about the documentation
@nociale ah, after sifting deeping into the emmeans documentation it looks like they do also support the counter factual approach with:
Will add this to our unit tests to ensure we match them |
@nociale, I updated the documentation and code according to our g-chat. I closed all the prior comments because its been reworked / rewritten a fair bit since your first review apologies. Would you mind re-reviewing now please. I also decided to delete all mentions of "weighting" in the |
Thank you Craig!! |
Closes #412
For reference the code changes are just:
.weights="equal"
implementation as my original code was very hard to read (no change in what it produces though)@export
tag to an S3 method (this was technical a bug could have caused some niche issues due to how R looks up s3 methods)