-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-7563 Docker images #11
Conversation
In particular, the `python27` and `nodejs-16` packages now are flagged as insecure.
cc41990
to
ec5fb98
Compare
Thanks a lot Brian! I will merge this version as it is but if you have some comments Guys please add them here.
@zeme-wana, @shlevy - can we leave it like that or should I introduce some simple config file which should be added to the app dir and overrides default value? |
I think a config file would ultimately be nicer, but this will work for now. |
Do we need a similar way to override the network name? Or is that inferred now? |
@shlevy the network is now inferred from the runtime |
@zeme-wana, @shlevy, @paluh, basd on our Sept 27 conversation, I created the bash script make-docker-image.sh that does the spago and webpack builds (from inside the
nix develop
shell) and then creates a Docker image.The Dockerfile uses
sed
to edit in the correctMARLOWE_WEB_SERVER_URL
just before launchingdarkhttpd
.Please review to see that this is sufficient for an interim deployment via docker.