Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-7563 Docker images #11

Merged
merged 6 commits into from
Sep 28, 2023
Merged

PLT-7563 Docker images #11

merged 6 commits into from
Sep 28, 2023

Conversation

bwbush
Copy link
Contributor

@bwbush bwbush commented Sep 22, 2023

@zeme-wana, @shlevy, @paluh, basd on our Sept 27 conversation, I created the bash script make-docker-image.sh that does the spago and webpack builds (from inside the nix develop shell) and then creates a Docker image.

The Dockerfile uses sed to edit in the correct MARLOWE_WEB_SERVER_URL just before launching darkhttpd.

Please review to see that this is sufficient for an interim deployment via docker.

@bwbush bwbush self-assigned this Sep 22, 2023
@bwbush bwbush force-pushed the PLT-7563 branch 3 times, most recently from cc41990 to ec5fb98 Compare September 27, 2023 19:46
@bwbush bwbush marked this pull request as ready for review September 27, 2023 20:01
@paluh
Copy link
Collaborator

paluh commented Sep 28, 2023

Thanks a lot Brian! I will merge this version as it is but if you have some comments Guys please add them here.

The Dockerfile uses sed to edit in the correct MARLOWE_WEB_SERVER_URL just before launching darkhttpd.

@zeme-wana, @shlevy - can we leave it like that or should I introduce some simple config file which should be added to the app dir and overrides default value?

@paluh paluh merged commit 488c3fd into main Sep 28, 2023
1 check passed
@shlevy
Copy link
Contributor

shlevy commented Sep 28, 2023

I think a config file would ultimately be nicer, but this will work for now.

@shlevy
Copy link
Contributor

shlevy commented Sep 28, 2023

Do we need a similar way to override the network name? Or is that inferred now?

@paluh
Copy link
Collaborator

paluh commented Sep 28, 2023

@shlevy the network is now inferred from the runtime /healthcheck response headers.

@paluh paluh deleted the PLT-7563 branch November 15, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants