Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): allow hiding dapps based on feature flag config [LW-11883] #1653

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

przemyslaw-wlodek
Copy link
Contributor

Checklist

  • JIRA
  • Proper tests implemented

Proposed solution

  • introduce Feature Flag payload validation
  • allow defining types for custom payloads
  • improve error handling
  • add new method PostHogClient.getFeatureFlagPayload()

Testing

Change the dapp-explorer feature flag config and see how/if Dapps are rendered

@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Jan 17, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 7d355a08

passed failed skipped flaky total result
Total 34 0 3 0 37

@szymonmaslowski szymonmaslowski force-pushed the feat/LW-11882-connect-to-dapp-radar branch from a80d784 to 78be196 Compare January 17, 2025 15:51
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/LW-11883-hide-dapps-using-feature-flags branch 5 times, most recently from 69822ea to 9cf2359 Compare January 20, 2025 10:14
Copy link
Contributor

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving a few comments.

@szymonmaslowski szymonmaslowski force-pushed the feat/LW-11883-hide-dapps-using-feature-flags branch 2 times, most recently from 23122e2 to d912d06 Compare January 21, 2025 10:47
Base automatically changed from feat/LW-11882-connect-to-dapp-radar to main January 21, 2025 13:34
@szymonmaslowski szymonmaslowski force-pushed the feat/LW-11883-hide-dapps-using-feature-flags branch 2 times, most recently from 62439c4 to c7505ec Compare January 21, 2025 19:44
- introduce Feature Flag payload validation
- allow defining types for custom payloads
- improve error handling
- add new method PostHogClient.getFeatureFlagPayload()
@szymonmaslowski szymonmaslowski force-pushed the feat/LW-11883-hide-dapps-using-feature-flags branch from c7505ec to 7d355a0 Compare January 21, 2025 22:29
@szymonmaslowski szymonmaslowski merged commit 23f78cb into main Jan 22, 2025
47 of 49 checks passed
@szymonmaslowski szymonmaslowski deleted the feat/LW-11883-hide-dapps-using-feature-flags branch January 22, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants