Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-12125] align assets search in assets picker #1647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Jan 16, 2025

Checklist

  • JIRA - LW-12125
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Existing (assets picker) behaviour allows searching nfts by name and tokens by name, description and id fields.

Allow searching nfts by name, assetId and policyId, allow searching tokens by name, policyId, fingerprint, ticker, so the behaviour is aligned with main search functionality on "Nfts" and "Tokens" tab respectively.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Jan 16, 2025
@vetalcore vetalcore requested a review from a team as a code owner January 16, 2025 23:10
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Jan 16, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for b3ca70de

passed failed skipped flaky total result
Total 34 0 3 0 37

@vetalcore vetalcore force-pushed the fix/lw-12125-align-assets-search-in-assets-picker branch 2 times, most recently from cb8d4c9 to 76866e3 Compare January 17, 2025 22:00
Copy link
Contributor

@greatertomi greatertomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vetalcore vetalcore force-pushed the fix/lw-12125-align-assets-search-in-assets-picker branch from 76866e3 to b3ca70d Compare January 21, 2025 08:55
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants