fix: [lw-10691]: add register as dRep banner and stake key raw info #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetalcore
commented
Nov 13, 2024
apps/browser-extension-wallet/src/features/delegation/components/DelegationLayout.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/views/browser-view/features/staking/components/Staking.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/features/delegation/components/DelegationLayout.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/features/delegation/components/Staking.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/views/browser-view/features/staking/components/Staking.tsx
Outdated
Show resolved
Hide resolved
packages/staking/src/features/overview/helpers/mapPortfolioToDisplayData.ts
Outdated
Show resolved
Hide resolved
Allure Report
processReports: ✅ test report for 89940042
|
vetalcore
force-pushed
the
feat/lw-10691-show-register-as-drep-banner-staking-center
branch
2 times, most recently
from
855201c
to
4d6b2b3
Compare
apps/browser-extension-wallet/src/views/browser-view/features/staking/components/Staking.tsx
Outdated
Show resolved
Hide resolved
| @@ -7,9 +7,11 @@ type MapPortfolioToDisplayDataParams = { | |||
| cardanoCoin: Wallet.CoinId; | |||
| cardanoPrice?: number; | |||
| portfolio: CurrentPortfolioStakePool[]; | |||
| poolIdToRewardAccountMap: Map<string | undefined, Wallet.Cardano.RewardAccountInfo>; | |||
There was a problem hiding this comment.
If a reward account is not delegated to a pool, it should not be part of this map:
- poolIdToRewardAccountMap: Map<string | undefined, Wallet.Cardano.RewardAccountInfo>
+ poolIdToRewardAccountMap: Map<string, Wallet.Cardano.RewardAccountInfo>| GOV_TOOLS_URL_MAINNET=https://gov.tools/ | ||
| GOV_TOOLS_URL_PREPROD= | ||
| GOV_TOOLS_URL_PREVIEW=https://preview.gov.tools/ | ||
| GOV_TOOLS_URL_SANCHONET= |
There was a problem hiding this comment.
We can use https://sanchogov.tools/ here.
mirceahasegan
approved these changes
Nov 14, 2024
…in staking center
vetalcore
force-pushed
the
feat/lw-10691-show-register-as-drep-banner-staking-center
branch
from
6eb9f02
to
8994004
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add register as dRep banner and stake key raw info in staking center
Checklist
Proposed solution
Testing
Testing should be done for both multi and single delegation flows, popup and browser view modes.
Screenshots
Attach screenshots here if implementation involves some UI changes