Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle modal closure after stake deregistration #1517

Merged

Conversation

AngelCastilloB
Copy link
Member

@AngelCastilloB AngelCastilloB commented Nov 6, 2024

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

First attempt to unstake using Ledger HW wallet does not work properly dues to incorrect handling of modals

Proposed solution

Close the correct modal after undelegation

@AngelCastilloB AngelCastilloB requested a review from a team as a code owner November 6, 2024 08:35
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Nov 6, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for f0c86789

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link

sonarcloud bot commented Nov 7, 2024

@AngelCastilloB AngelCastilloB merged commit 505476d into main Nov 7, 2024
31 of 32 checks passed
@AngelCastilloB AngelCastilloB deleted the fix/LW-11762-first-attemp-to-unstake-doesnt-work-properly branch November 7, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants