feat: providers are now consumed from the service worker instead of the UI script #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 0e3be854
|
AngelCastilloB
force-pushed
the
feat/LW-11761-remove-direct-use-of-providers-from-ui
branch
from
aa76a7e
to
708ab95
Compare
mkazlauskas
requested changes
Oct 31, 2024
apps/browser-extension-wallet/src/lib/scripts/background/wallet.ts
Outdated
Show resolved
Hide resolved
AngelCastilloB
force-pushed
the
feat/LW-11761-remove-direct-use-of-providers-from-ui
branch
5 times, most recently
from
eef4969
to
1a6f787
Compare
AngelCastilloB
force-pushed
the
feat/LW-11761-remove-direct-use-of-providers-from-ui
branch
from
2828a83
to
98f3206
Compare
…ad of the UI script
…ad of the UI script
…ad of the UI script
…ad of the UI script
…ad of the UI script
AngelCastilloB
force-pushed
the
feat/LW-11761-remove-direct-use-of-providers-from-ui
branch
from
5fd527f
to
0e3be85
Compare
|
AngelCastilloB
deleted the
feat/LW-11761-remove-direct-use-of-providers-from-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider objects (or at least an instance of RateLimiter) must be shared between SW and UI.
Checklist
Proposed solution
UI script now consumes Provider objects instead of creating their own providers