Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-11753] do not show address suggestion dropdown if there are … #1502

Merged

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Oct 30, 2024

…no addresses

Checklist

  • JIRA - LW-11753
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Oct 30, 2024
@vetalcore vetalcore requested a review from a team as a code owner October 30, 2024 13:17
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Oct 30, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 46a8d023

passed failed skipped flaky total result
Total 32 0 4 0 36

@vetalcore vetalcore force-pushed the fix/lw-11753-fix-empty-address-suggestion-dropdown-send-flow branch from 200010c to 46a8d02 Compare October 31, 2024 08:31
Copy link

sonarcloud bot commented Oct 31, 2024

@vetalcore vetalcore merged commit 2af5bbf into main Oct 31, 2024
30 checks passed
@vetalcore vetalcore deleted the fix/lw-11753-fix-empty-address-suggestion-dropdown-send-flow branch October 31, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants