Fix/lw 11758 error not displayed setting collateral with insufficient balance #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 2defe29e
|
vetalcore
approved these changes
Oct 28, 2024
mirceahasegan
approved these changes
Oct 29, 2024
|
mchappell
deleted the
fix/lw-11758-error-not-displayed-setting-collateral-with-insufficient-balance
branch
mchappell
added a commit
that referenced
this pull request
Oct 29, 2024
…ufficient balance (#1493) * fix(nami): reset collateral data on modal close * fix(nami): correctly await setting collateral * fix(nami): init collateral explicitly checks available utxos * fix(nami): clear pw secrets on collateral modal close * fixup! fix(nami): init collateral explicitly checks available utxos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Correctly await the response from setting collateral before continuing rest of the chained functions
Testing
Notes added to linked ticket
Screenshots
Attach screenshots here if implementation involves some UI changes