Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LW-11760] fix: bump cardano-js-sdk and utilize computeWalletId for wallet repository storage #1484

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mkazlauskas
Copy link
Member

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

See input-output-hk/cardano-js-sdk#1518

@cardano-sdk/wallet has a fix to preserve the existing collection
documents by id when using CollectionStorage.setAll function

This will hopefully resolve the production bug where
users wallets gets broken for no apparent reason
@mkazlauskas mkazlauskas requested a review from a team as a code owner October 25, 2024 14:27
Copy link

sonarcloud bot commented Oct 25, 2024

@pczeglik-iohk
Copy link
Contributor

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for eb47e679

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkazlauskas mkazlauskas merged commit c87b43c into main Oct 28, 2024
31 of 32 checks passed
@mkazlauskas mkazlauskas deleted the fix/wallet-repository-drop branch October 28, 2024 13:06
mchappell pushed a commit that referenced this pull request Oct 28, 2024
…allet repository storage (#1484)

* chore: bump cardano-js-sdk package versions

* fix: add computeDocId function to wallet repository storage

@cardano-sdk/wallet has a fix to preserve the existing collection
documents by id when using CollectionStorage.setAll function

This will hopefully resolve the production bug where
users wallets gets broken for no apparent reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants