-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change password flow #1466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for b5968ebe
|
mirceahasegan
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @vetalcore !
vetalcore
force-pushed
the
fix/change-password-flow
branch
from
October 11, 2024 14:52
92858ef
to
b5968eb
Compare
Quality Gate passedIssues Measures |
mchappell
added a commit
that referenced
this pull request
Oct 22, 2024
* feat: nami mode dapp connector * feat(extension): conditional inject based on wallet mode (#91) Implements LW-11590 and LW-11630 * chore: resolve sonarcloud issues * fixup! feat(extension): conditional inject based on wallet mode (#91) * fixup! feat: nami mode dapp connector * feat(extension): collateral logic * fixup! feat: nami mode dapp connector * fixup! feat: nami mode dapp connector * chore: bump sdk version * fix: hardware wallet integration * fix: banner display condition and popup size * chore: resolve ci issues * chore: fix ui discrepancies * fixup! fix: hardware wallet integration * fixup! fixup! fix: hardware wallet integration * feat(nami): await posthog events that occur before window.close Window.close could occur before the posthog event is sent. Await on sending the event before closing the window. * fixup! chore: resolve ci issues * fixup! fix: banner display condition and popup size * fixup! fix: hardware wallet integration * fixup! fix: banner display condition and popup size * fix(extension): debounce on CIP-30 endpoint calls now starts after first event (#1458) * fix(extension): debounce on CIP-30 endpoint calls now starts after first event * perf: optimize loading states in Dapp connector views * chore: separate dapp view * feat: optimize loading states in Dapp connector views --------- Co-authored-by: Przemysław Włodek <[email protected]> Co-authored-by: Mircea Hasegan <[email protected]> Co-authored-by: vetalcore <[email protected]> * fix: improve error handling for hardware wallet * fixup! fix: hardware wallet integration * chore: extract more tools (#1461) * chore: extract more tools * chore: update assets * fix: preserve location * fix: hide show recovery phrase setting * fix: [LW-11665] dApp connector proportions for hardware wallets (#1467) * fix: change password flow (#1466) * fix: change password flow * chore: fix tests * chore(extension): ensure tabs are closed (#1464) * fix: delete wallet from popup (#1465) * chore: update copy * chore: remove tslint issues * chore: resolve sonarcloud issues * fix: correct copy paste error for extension IDs * fix: scrollbar ref potentially not active * fix: metadata controlled input lag * chore: fix get collateral utxo test * fix: collateral confirmation toast * fix(nami): tx collateral inputs must be part of marked collaterals * fix: handle server urls * fix: fix unresponsive send page on metadata update with multiple assets * chore: update switch to nami mode copies * fix: store recent addresses per env name for send flow * fix: resolve eslint/tslint fixes commit comments * chore: update switch to nami mode copies * chore: add missing dependencies into dapp connector view * feat: show asset info in assets modal * fix: redirect to trezor sign page * fix: allow additional properties while sending events to posthog * chore: fix tslint issues * fix: fix change password flow * chore: fix tslint issues * fix: refresh tx history if new tx appears * fix: cache address and balance per env name * chore(nami): add missing typings * fix: reset states after submitting tx with trezor * fix: close all lace windows before executing migration * fix: show tx history of multi-delegated accounts * feat(nami): implement migration guard on popup - only complete migration via explicit complete in final onboarding step * fix: show all accounts of all hw instead of just a first one * fixup! feat: show asset info in assets modal * fix: use explicit bigint conversion in both sides of abs function * fix: use explicit bigint conversion in both sides of abs function * refactor: address sonarlint issues * fix: update account tests * fixup! fix(nami): tx collateral inputs must be part of marked collaterals * fix: remove second scrollbar in history tab * refactor: remove dead code * feat(nami): send analytic event for trezor dapp tx sign * fix: add analytic event for ledger send tx * fix(nami): asset meatadata with bigint values * fix: add send transaction confirmation click event for trezor * fix: open HWFlow modal if wallet type is hardware * fix(nami): compute datumHash if contract * fix: nami package storybook * fix: confirm modal event capture relative paths need to be used * fix(nami): broken HW connect UI (#1476) --------- Co-authored-by: Mircea Hasegan <[email protected]> Co-authored-by: Angel Castillo <[email protected]> Co-authored-by: Przemysław Włodek <[email protected]> Co-authored-by: John Oshalusi <[email protected]> Co-authored-by: Michael Chappell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes