Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [lw-11532] add analytics for shared wallet #1462

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Oct 7, 2024

Checklist

  • JIRA -LW-11532
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Oct 7, 2024
@vetalcore vetalcore requested a review from a team as a code owner October 7, 2024 21:36
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Oct 7, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 366400f8

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@greatertomi greatertomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done @vetalcore 🚀

Copy link

sonarcloud bot commented Oct 22, 2024

@mchappell mchappell merged commit c636a4b into main Oct 22, 2024
29 checks passed
@mchappell mchappell deleted the feat/lw-11532-analytics-for-shared-wallet branch October 22, 2024 09:54
@mchappell mchappell restored the feat/lw-11532-analytics-for-shared-wallet branch October 22, 2024 09:54
@mchappell mchappell deleted the feat/lw-11532-analytics-for-shared-wallet branch October 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants