-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [lw-11532] add analytics for shared wallet #1462
Conversation
Allure Report
processReports: ✅ test report for 366400f8
|
...extension-wallet/src/views/browser-view/components/TransactionCTAsBox/TransactionCTAsBox.tsx
Outdated
Show resolved
Hide resolved
...rc/views/browser-view/features/send-transaction/components/ImportSharedWalletTransaction.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
...src/views/browser-view/features/send-transaction/components/SendTransactionDrawer/Footer.tsx
Outdated
Show resolved
Hide resolved
...src/views/browser-view/features/send-transaction/components/SendTransactionDrawer/Footer.tsx
Outdated
Show resolved
Hide resolved
...src/views/browser-view/features/send-transaction/components/SendTransactionDrawer/Footer.tsx
Outdated
Show resolved
Hide resolved
...src/views/browser-view/features/send-transaction/components/SendTransactionDrawer/Footer.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/views/browser-view/features/shared-wallet/SharedWallet.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/shared-wallets/add-shared-wallet/SharedWalletLayout/type.ts
Outdated
Show resolved
Hide resolved
...src/shared-wallets/add-shared-wallet/creation-flow/ShareWalletDetails/ShareWalletDetails.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/shared-wallets/add-shared-wallet/creation-flow/SharedWalletCreationFlow.tsx
Outdated
Show resolved
Hide resolved
...extension-wallet/src/views/browser-view/components/TransactionCTAsBox/TransactionCTAsBox.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Well done @vetalcore 🚀
Quality Gate passedIssues Measures |
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes