Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework CI #1097

Merged
merged 4 commits into from
May 17, 2024
Merged

Rework CI #1097

merged 4 commits into from
May 17, 2024

Conversation

pczeglik-iohk
Copy link
Contributor

@pczeglik-iohk pczeglik-iohk commented Apr 23, 2024

Checklist

  • JIRA: LW-10413
  • Proper tests implemented
  • Screenshots added.

@pczeglik-iohk pczeglik-iohk force-pushed the main-ci-rework branch 3 times, most recently from 3113bba to 402c85a Compare April 23, 2024 17:03
Copy link

github-actions bot commented Apr 23, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 886700e4

passed failed skipped flaky total result
Total 30 0 0 0 30

@pczeglik-iohk pczeglik-iohk force-pushed the main-ci-rework branch 26 times, most recently from bd6b8ee to e946682 Compare April 24, 2024 10:23
@pczeglik-iohk pczeglik-iohk requested a review from a team as a code owner April 26, 2024 13:57
@pczeglik-iohk pczeglik-iohk marked this pull request as draft April 29, 2024 10:54
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@@ -29,12 +29,14 @@
"build:dev": "NODE_OPTIONS='--openssl-legacy-provider' rm -rf dist & run -T webpack --config webpack.sw.dev.js --progress & run -T webpack --config webpack.app.dev.js --progress",
"cleanup": "yarn exec rm -rf dist node_modules",
"dev": "NODE_OPTIONS='--openssl-legacy-provider' rm -rf dist & run -T webpack --config webpack.sw.dev.js --progress --watch & run -T webpack serve --config webpack.app.dev.js --env RUN_DEV_SERVER=true",
"format-check": "echo \"@lace/browser-extension-wallet: no format-check command specified\"",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a contract between CI and the package / app. It must expose those commands in package json:

  • format-check
  • lint
  • type-check
  • build
  • test

In most cases I mocked those methods as this is out of the scope for this PR

- 'release/**'

permissions:
pull-requests: write
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this permission is needed for catchpoint/workflow-telemetry-action@v2 action

# Packages Teams
/packages/cardano/ @input-output-hk/lace-core
/packages/common/ @input-output-hk/lace-core
/packages/core/ @input-output-hk/lace-core
/packages/e2e-tests/ @input-output-hk/lace-test-engineers
/packages/icons/ @input-output-hk/lace-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been missed when icons package has been created.

@pczeglik-iohk pczeglik-iohk force-pushed the main-ci-rework branch 4 times, most recently from 4d17b2d to 73d064c Compare May 8, 2024 09:47
@pparker
Copy link

pparker commented May 14, 2024

@pczeglik-iohk - what Jira ticket is this PR related to? It's mentioned in this comment in https://input-output.atlassian.net/browse/LW-10075, so - maybe that one?
~JON

@pczeglik-iohk pczeglik-iohk force-pushed the main-ci-rework branch 2 times, most recently from 0213e54 to 92e177b Compare May 16, 2024 09:57
@pczeglik-iohk pczeglik-iohk marked this pull request as ready for review May 16, 2024 09:57
Copy link
Contributor

@emiride emiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pczeglik-iohk pczeglik-iohk force-pushed the main-ci-rework branch 3 times, most recently from 68ae5e1 to f93c086 Compare May 17, 2024 08:14
Copy link
Collaborator

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great rework! 🍻

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pczeglik-iohk pczeglik-iohk merged commit cbf43f9 into main May 17, 2024
18 checks passed
@pczeglik-iohk pczeglik-iohk deleted the main-ci-rework branch May 17, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants