-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework CI #1097
Rework CI #1097
Conversation
3113bba
to
402c85a
Compare
Allure Report
smokeTests: ✅ test report for 886700e4
|
bd6b8ee
to
e946682
Compare
ca2047a
to
31e15f9
Compare
@@ -29,12 +29,14 @@ | |||
"build:dev": "NODE_OPTIONS='--openssl-legacy-provider' rm -rf dist & run -T webpack --config webpack.sw.dev.js --progress & run -T webpack --config webpack.app.dev.js --progress", | |||
"cleanup": "yarn exec rm -rf dist node_modules", | |||
"dev": "NODE_OPTIONS='--openssl-legacy-provider' rm -rf dist & run -T webpack --config webpack.sw.dev.js --progress --watch & run -T webpack serve --config webpack.app.dev.js --env RUN_DEV_SERVER=true", | |||
"format-check": "echo \"@lace/browser-extension-wallet: no format-check command specified\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a contract between CI and the package / app. It must expose those commands in package json:
- format-check
- lint
- type-check
- build
- test
In most cases I mocked those methods as this is out of the scope for this PR
- 'release/**' | ||
|
||
permissions: | ||
pull-requests: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this permission is needed for catchpoint/workflow-telemetry-action@v2
action
# Packages Teams | ||
/packages/cardano/ @input-output-hk/lace-core | ||
/packages/common/ @input-output-hk/lace-core | ||
/packages/core/ @input-output-hk/lace-core | ||
/packages/e2e-tests/ @input-output-hk/lace-test-engineers | ||
/packages/icons/ @input-output-hk/lace-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been missed when icons package has been created.
4d17b2d
to
73d064c
Compare
@pczeglik-iohk - what Jira ticket is this PR related to? It's mentioned in this comment in https://input-output.atlassian.net/browse/LW-10075, so - maybe that one? |
0213e54
to
92e177b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
68ae5e1
to
f93c086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great rework! 🍻
f313a08
to
886700e
Compare
Quality Gate passedIssues Measures |
Checklist