add separate explorer service #2467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
5ca7915
to
5c7253c
Compare
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
5c7253c
to
10afb4e
Compare
the serialization can change, but use json for now
add also setting to configuration builder, in order to test it, and improve the panic handling of the notifier client
in order to avoid platform specific dependencies in Cargo.lock
the new connection requests are handled through a new message tip changes are handled with tokio::watch because we only care about the latest state, but block changes use a broadcast to keep old ones too
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
941a3f0
to
7c6c721
Compare
ecioppettini
force-pushed
the
extract-explorer
branch
from
da054dd
to
7c6e0f7
Compare
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
7c6c721
to
5c92bf8
Compare
7 tasks
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
5c92bf8
to
1cc7bf3
Compare
3 tasks
|
I'll open a new PR more according with the new plans. (and with the current graphql api) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate explorer service (wip)
NOTE: this depends on #2378 (note the base branch)
Start moving the explorer outside of the node into a subcrate.
There are still a lot of questions of what's the best way to move forward with this, so this is mostly to start somewhere. The idea was to just copy-paste the the whole API but there are some part of the indexing process that depend on the ledger/blockchain object (particularly all the vote counting). Shouldn't be that hard to extract, but maybe it's better to do it after starting with the storage.
The logging part is fairly simple to get started, but ideally we should reuse the same setup (configuration) that the node uses.
The warp/api setup should be the same too, not sure how worth it is to share it.
There are more details, but may be better to create an issue to keep track of everything (todo)