Add system to outputs.nix #92
Conversation
WalkthroughThe changes primarily focus on enhancing the project's cross-platform compatibility. A new function Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Files selected for processing (1)
- dapps-certification-helpers/data/outputs.nix (1 hunks)
Additional comments (Suppressed): 1
dapps-certification-helpers/data/outputs.nix (1)
- 63-68: Ensure that all references to the
defaultPackageandpackagesthroughout the codebase have been updated to match the new structure.
| defaultPackage.x86_64-linux = certify; | ||
| packages.x86_64-linux.default = certify; | ||
|
|
||
| mkCertity = system: let |
There was a problem hiding this comment.
Typo in function name mkCertity, it should be mkCertify.
- mkCertity = system: let
+ mkCertify = system: let | exportReferencesGraph.plutus-apps = dapps-certification; | ||
| __structuredAttrs = true; | ||
| PATH = pkgs.lib.makeBinPath [ pkgs.coreutils pkgs.jq ]; | ||
| builder = builtins.toFile "builder" '' | ||
| . .attrs.sh | ||
| jq '."plutus-apps"[0].narHash' < .attrs.json > "$(jq -r .outputs.out < .attrs.json)" | ||
| ''; |
There was a problem hiding this comment.
The exportReferencesGraph.plutus-apps should be exportReferencesGraph.dapps-certification as we are dealing with the dapps-certification repository here.
- exportReferencesGraph.plutus-apps = dapps-certification;
+ exportReferencesGraph.dapps-certification = dapps-certification;
|
@Ali-Hill should we squash those 3 commits and merge it? |
|
That's a good idea. I have removed the other two commits |
This allows for the tool to work with the iogx version of the minimal examples
bogdan-manole
force-pushed
the
iogx-fix
branch
from
7bda96c
to
09626b6
Compare
This allows for the tool to work with the iogx version of the minimal examples
Summary by CodeRabbit
mkCertifythat allows generation of thecertifyexecutable for different systems.defaultPackageto include separate entries forx86_64-linuxandx86_64-darwinsystems, enhancing system compatibility.origProjectfromrepo.iog.dapptorepo.iog.x86_64-linux.dapp, improving project specificity.