Update .gitignore && add dockerApps.evaluation-test to CI #87

zeme-wana · 2023-08-10T07:22:34Z

Things that slipped through the previous PR

Summary by CodeRabbit

Refactor:

Updated the path for Docker app in nix/ci.nix.
Modified the values of genFlake and buildFlake variables in nix/docker-files/docker.nix.
Changed the defaultPackage attribute value in nix/per-system-outputs.nix.

Chore:

Added .pre-commit-config.yaml to .gitignore.

🐇💻

"In the land of code, where logic intertwines,
A rabbit hops along the lines.
Paths are changed, variables renamed,
Yet the essence of the code remained.
With every commit, we refine,
In this digital world, we shine! 🌟"

coderabbitai · 2023-08-10T07:22:38Z

CodeRabbit

Walkthrough

The changes in this pull request primarily involve updates to the Nix and Docker configuration files. The modifications include adjustments to package paths, renaming of variables, and alterations to default package attributes. These changes do not appear to affect the core functionality of the application but rather seem to be aimed at improving the build and deployment process.

Changes

File(s)	Summary
`.gitignore`	A new file `.pre-commit-config.yaml` has been added to the project.
`nix/ci.nix`	The path of a Docker app included in the project has been updated from "dockerApps.evaluation-test" to "apps.dockerApps.evaluation-test".
`nix/docker-files/docker.nix`	The values of `genFlake` and `buildFlake` variables have been updated to use different package names (`generate-flake` and `build-flake`).
`nix/per-system-outputs.nix`	The `defaultPackage` attribute in the Nix expression has been modified from `inputs'.self.packages.plutus-certification-exe-plutus-certification-ghc927` to `inputs'.self.packages.plutus-certification`.

coderabbitai

CodeRabbit

Commits

Files that changed from the base of the PR and between 4939cab and 6f0564d commits.

Files selected for processing (2)

.gitignore (1 hunks)
nix/ci.nix (1 hunks)

Files skipped from review due to trivial changes (1)

.gitignore

Review comments generated (0)

Actionable : 0
LGTM (Skipped): 0
Noise Suppression (Skipped): 1

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

Tag the bot with @coderabbitai in any review comment to ask it questions. The bot will not respond unless explicitly tagged.
A review comment is a comment on a diff or a file and not a comment on the PR itself.
You can use the mouse to select multiple lines of code to provide exact context to the bot.

Code suggestions

The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

coderabbitai

CodeRabbit

Commits

Files that changed from the base of the PR and between 6f0564d and 6b0f63c commits.

Files ignored due to filter (1)

flake.lock

Files selected for processing (2)

nix/docker-files/docker.nix (1 hunks)
nix/per-system-outputs.nix (1 hunks)

Files skipped from review due to trivial changes (2)

nix/docker-files/docker.nix
nix/per-system-outputs.nix

Review comments generated (0)

Actionable : 0
LGTM (Skipped): 0
Noise Suppression (Skipped): 0

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

Tag the bot with @coderabbitai in any review comment to ask it questions. The bot will not respond unless explicitly tagged.
A review comment is a comment on a diff or a file and not a comment on the PR itself.
You can use the mouse to select multiple lines of code to provide exact context to the bot.

Code suggestions

The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

zeme-wana · 2023-08-10T08:23:50Z

nix/docker-files/docker.nix

@@ -64,8 +64,8 @@
      finalImageName = "nixos/nix";
      finalImageTag = "2.15.0";
    };
-    genFlake = inputs'.self.packages.dapps-certification-helpers-exe-generate-flake-ghc927;


Aliases for your cabal executables only (this excludes benchmarks and test suites) are added to your packages and apps flake outputs.
Alias means just the executable name as found in your cabal file, without the $CabalPackageName-exe- prefix.

For projects supporting a single compiler (like in this repo, ghc927), the compiler name is no longer appended to the flake outputs names.

inputs'.self.packages.dapps-certification-helpers-exe-generate-flake-ghc927 -> inputs'.self.packages.generate-flake inputs'.self.apps.dapps-certification-exe-plutus-certificatio-ghc927 -> inputs'.self.apps.plutus-certification

If you cabal project has multiple executables with the same name across your cabal files, a warning will be generated when running list-flake-outputs and no aliases will be created.

bogdan-manole

lgtm

coderabbitai

CodeRabbit

Commits

Files that changed from the base of the PR and between 6b0f63c and 0126941 commits.

Files ignored due to filter (1)

flake.lock

Files selected for processing (1)

nix/docker-files/docker.nix (1 hunks)

Files skipped from review due to trivial changes (1)

nix/docker-files/docker.nix

Review comments generated (0)

Actionable : 0
LGTM (Skipped): 0
Noise Suppression (Skipped): 0

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

Tag the bot with @coderabbitai in any review comment to ask it questions. The bot will not respond unless explicitly tagged.
A review comment is a comment on a diff or a file and not a comment on the PR itself.
You can use the mouse to select multiple lines of code to provide exact context to the bot.

Code suggestions

The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

zeme-wana · 2023-08-18T09:10:21Z

@bogdan-manole are we ok with the CI Tests / tests failing? I see that they are red on the main branch too.

bogdan-manole · 2023-08-22T13:08:57Z

@bogdan-manole are we ok with the CI Tests / tests failing? I see that they are red on the main branch too.

yes, that's ok, anyway react part will be removed from this repo

Update .gitignore && add dockerApps.evaluation-test to CI

6f0564d

coderabbitai bot reviewed Aug 10, 2023

View reviewed changes

zeme-wana requested a review from bogdan-manole August 10, 2023 08:07

zeme-wana added 2 commits August 10, 2023 10:10

Bump IOGX

106dcca

WIP

6b0f63c

zeme-wana removed the request for review from bogdan-manole August 10, 2023 08:13

coderabbitai bot reviewed Aug 10, 2023

View reviewed changes

Bump IOGX

a52013b

zeme-wana commented Aug 10, 2023

View reviewed changes

zeme-wana requested review from bogdan-manole and RSoulatIOHK August 10, 2023 08:25

Bump IOGX

6fdda2c

bogdan-manole approved these changes Aug 16, 2023

View reviewed changes

Merge branch 'master' into iogx-fixolino

0126941

coderabbitai bot reviewed Aug 18, 2023

View reviewed changes

zeme-wana merged commit 1b431da into master Aug 22, 2023
4 of 6 checks passed

bogdan-manole deleted the iogx-fixolino branch January 31, 2024 11:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update .gitignore && add dockerApps.evaluation-test to CI #87

Update .gitignore && add dockerApps.evaluation-test to CI #87

zeme-wana commented Aug 10, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 10, 2023 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

zeme-wana Aug 10, 2023 •

edited

Loading

bogdan-manole left a comment

coderabbitai bot left a comment

zeme-wana commented Aug 18, 2023

bogdan-manole commented Aug 22, 2023

Update .gitignore && add dockerApps.evaluation-test to CI #87

Update .gitignore && add dockerApps.evaluation-test to CI #87

Conversation

zeme-wana commented Aug 10, 2023 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Aug 10, 2023 • edited Loading

Walkthrough

Changes

coderabbitai bot left a comment

Choose a reason for hiding this comment

Chat with CodeRabbit Bot (@coderabbitai)

Code suggestions

Pausing incremental reviews

coderabbitai bot left a comment

Choose a reason for hiding this comment

Chat with CodeRabbit Bot (@coderabbitai)

Code suggestions

Pausing incremental reviews

zeme-wana Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

bogdan-manole left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

Chat with CodeRabbit Bot (@coderabbitai)

Code suggestions

Pausing incremental reviews

zeme-wana commented Aug 18, 2023

bogdan-manole commented Aug 22, 2023

zeme-wana commented Aug 10, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 10, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

Chat with CodeRabbit Bot (`@coderabbitai`)

zeme-wana Aug 10, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)