-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(ci): Bump Rust Versions & Alpine Versions, add ADR for rust-ver…
…sions (#180) * chore(cat-ci): Bup rust tooling dependencies, and add wit-bindgen-cli as a tool to the rust base image * chore(cat-ci): Bump all possible alpine container versions to 3.19 * fix(docs): Fix CIP header in docs. * docs(ADR): Add adr about rust-version * docs(ADR): Add scope section to ADR to show they apply to all subordinate repos, unless otherwise defined. * fix(rust): Fix wit-bindgen-cli binary name in install * docs(cspell): fix spelling * fix(postgresql): sqlfluff not a standard alpine package, but still install system wide. * fix(rust): Fix command lines for `cargo modules` due to tool version changes. * fix(postgresql): fix string concat generating rust build graphs * docs(cspell): fix spelling * feat(rust): Allow BSD-2-Clause license in dependencies for Rust
- Loading branch information
Showing
25 changed files
with
148 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...c/architecture/09_architecture_decisions/0007-minimum-rust-version-supported.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
--- | ||
title: 0007 Rust Version configuration in `cargo.toml` | ||
adr: | ||
author: Steven Johnson | ||
created: 21-Jan-2024 | ||
status: accepted | ||
extends: | ||
- 0005-rust | ||
tags: | ||
- Rust | ||
--- | ||
|
||
## Context | ||
|
||
In the Rust`cargo.toml` it is possible to specify a minimum version of Rust supported by a Crate/Application. | ||
This rust projects which consume crates to ensure they or on a supported version. | ||
There should be a policy about How many old versions of Rust is supported by our project. | ||
|
||
## Assumptions | ||
|
||
This ADR is deliberately limited to the initial bring up phase of our projects, and subject to review. | ||
|
||
## Decision | ||
|
||
We will not use the `rust-version` feature of `cargo.toml` during initial bring up. | ||
We have not defined a maximum range of valid Rust versions, and always build ONLY with the version defined in `rust-toolchain.toml`. | ||
|
||
Currently the ONLY supported rust version is the one specified by `rust-toolchain.toml`. | ||
|
||
If at a later time, a range of rust versions is decided to be supported then: | ||
|
||
* This ADR will be obsoleted by a new one which defines that range of supported versions. | ||
* The allowable range will need to be enforced in CI to ensure a `Cargo.toml` file does not specify the wrong thing. | ||
* All Rust versions in that range will need to be tested in CI to ensure they are properly supported. | ||
|
||
## Risks | ||
|
||
None, this decision is subject to review at any time. | ||
|
||
## Consequences | ||
|
||
Development should be easier, and CI faster as we are specifically locked to a single Rust toolchain version. | ||
|
||
## Scope | ||
|
||
This ADR applies to all projects which consume `Catalyst-CI` unless they define an ADR specific to that project. | ||
|
||
## More Information | ||
|
||
* [`rust-version` field](https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.