-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): repurpose blockfrost test suite for direct from client providers #1531
Conversation
6d711bf
to
95d1e2a
Compare
|
…ile metadata it used to have same logic for both, but they have different schema therefore some properties were not correctly classified as 'otherProperties'
60af9f0
to
3e0c8e2
Compare
…viders - Align "Continuous Integration - E2E BF" GHA workflow to be the same as regular e2e, but using BlockfrostAssetProvider. We will be updating it to use more Blockfrost providers as we refactor them to be browser compatible - Update .env.example to be able to run Blockfrost e2e tests locally - Simplify (reduce scope of) some assertions in nft.test.ts because, BlockfrostAssetProvider has some fixes and returns slightly different object. For example, it correctly does not put 'version' as otherProperties - Temporarily disable CIP25 v2 test when running with BlockfrostAssetProvider, there is an on-going investigation by the Blockfrost team
This reverts commit d5674cd.
3e0c8e2
to
27cf4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mkazlauskas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work, lgtm
Context
LW-11696
Proposed Solution
See notes in the commit messages
Important Changes Introduced