Feat/lw 11842 performance improvements #1530
Draft
+561
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mkazlauskas
reviewed
Nov 14, 2024
|
Added more unit tests for rollback behaviour here: 6d0e216 |
This change is needed to fix tests because transactions tracker is relying on accurate block range fetches from chain history provider.
| @@ -152,13 +152,15 @@ const findIntersectionAndUpdateTxStore = ({ | |||
| lowerBound !== undefined && `since block ${lowerBound}` | |||
| ); | |||
|
|
|||
| const txRolledBack = lastStoredTransaction && newTransactions[0]?.id !== lastStoredTransaction.id; | |||
| const txRolledBack = | |||
| lastStoredTransaction && newTransactions[newTransactions.length - 1]?.id !== lastStoredTransaction.id; | |||
There was a problem hiding this comment.
I think this should be looking only at the first block from newTransactions
- lastStoredTransaction && newTransactions[newTransactions.length - 1]?.id !== lastStoredTransaction.id;
+ const newTxFirstBlock = newTransactions.filter(tx => tx.blockHeader.blockNo === lowerBound);
+ lastStoredTransaction && newTxFirstBlock[newTxFirstBlock.length - 1]?.id !== lastStoredTransaction.id;There was a problem hiding this comment.
I am rewriting this logic here, sec
| @@ -280,6 +280,42 @@ describe('TransactionsTracker', () => { | |||
| pagination: { limit: 25, startAt: 0 } | |||
| }); | |||
| }); | |||
|
|
|||
| describe('distinct transaction sets in latest stored block vs new blocks', () => { | |||
There was a problem hiding this comment.
@mkazlauskas , @AngelCastilloB , please review these proposed scenarios to cover in unit tests.
If they make sense and improve coverage I will implement them.
There was a problem hiding this comment.
Looks good 💪 , just don't quite understand when/how this could happen reversed order transactions plus new tx are re-emitted, but not considered rollbacks
There was a problem hiding this comment.
It is far fetched, but I was thinking of a scenario where a competing SP has txId 3 in the mempool, then gets a mempool update with txId 2, then another with txId 1, and creates a fork with the 3 transactions <3 2 1>.
I'm not sure if that is even possible tbh 😅
There was a problem hiding this comment.
Looks great @mirceahasegan , I think we just need to add the case where there are no changes somewhere:
// latestStoredBlock <1 2 3>
// fetched Txs <1 2 3>
Or is it that this is already covered by the already existing tests?
There was a problem hiding this comment.
Thanksk @mirceahasegan , better safe than sorry 😅
There was a problem hiding this comment.
I would say it's already covered in the other tests, for single transaction blocks.
I'll add one for the multi-transaction block scenario too, just to be safe.
There was a problem hiding this comment.
Unit tests are implemented in ef247ea.
The commit also contains a fix for an issue discovered in tx tracker.
There still are ~3 tests that are failing and we need to investigate if they're bugs or test issues after updating implementation
There was a problem hiding this comment.
all tests are green now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
TBD
Proposed Solution
TBD
Important Changes Introduced
TBD