Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable dev-mainnet asset provider #1515

Closed
wants to merge 2 commits into from
Closed

chore: enable dev-mainnet asset provider #1515

wants to merge 2 commits into from

Conversation

bernokl
Copy link
Contributor

@bernokl bernokl commented Oct 21, 2024

Context

Enable asset-provider on dev-mainnewt. Disable asset on monolith

iccicci
iccicci approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mirceahasegan
mirceahasegan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gytis-ivaskevicius
gytis-ivaskevicius requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@gytis-ivaskevicius gytis-ivaskevicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either keep asset provider on monolithic backend or enable provider everywhere

Leaving it enabled is fine, it's not going to get hit anyway

@iccicci
Copy link
Contributor

iccicci commented Oct 21, 2024

Please either keep asset provider on monolithic backend or enable provider everywhere

Leaving it enabled is fine, it's not going to get hit anyway

Nice catch! Yes, please enable asset-provider everywhere.

@bernokl
Copy link
Contributor Author

bernokl commented Oct 29, 2024

@iccicci is this PR still relevant? or can I close it?

@bernokl bernokl closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gytis-ivaskevicius gytis-ivaskevicius gytis-ivaskevicius requested changes

@mirceahasegan mirceahasegan mirceahasegan approved these changes

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas Awaiting requested review from mkazlauskas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bernokl @iccicci @gytis-ivaskevicius @mirceahasegan