-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): one ledger-tip req per pollInterval #1514
fix(wallet): one ledger-tip req per pollInterval #1514
Conversation
WHAT: replaced `delay` operator with `auditTime` operator, which starts a timer once the first isSettled$ emission, and emits the last value, ignoring previous ones. WHY: isSettled$ observable emissions triggered ledger-tip requests, delayed by pollingInterval. Flapping isSettled$ caused multiple requests to be done, because the flapping was delayed. Throttling is in place for the case where the ledger-tip request is not resolved yet.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💪
Context
More ledger-tip requests per polling interval occur.
Proposed Solution
WHAT: replaced
delay
operator withauditTime
operator, which starts a timer once the first isSettled$ emission, and emits the last value, ignoring previous ones.WHY: isSettled$ observable emissions triggered ledger-tip requests, delayed by pollingInterval.
Flapping isSettled$ caused multiple requests to be done, because the flapping was delayed.
Throttling is in place for the case where the ledger-tip request is not resolved yet.
Important Changes Introduced