-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: hoist bufferChainSyncEvent to projection package #1486
refactor!: hoist bufferChainSyncEvent to projection package #1486
Conversation
37436b1
to
6423409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just not sure about the commit message:
- typically if you add both
!
in the header andBREAKING CHANGE:
in the footer it would create 2 entries for breaking changes in the CHANGELOG, so 1 of the 2 is enough - Not sure the footer will be picked up in this case, because:
- it doesn't have commit message body
- footer is the co-authored message
<header>
<body>
<footer>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
I also noticed the required dependency not listed in package.json
file a couple of days ago... but I had no time yet to investigate it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀 Please update the commit message as discussed on Slack so that I'm not listed a breaking change 😅
Co-authored-by: Martynas Kazlauskas <[email protected]> BREAKING CHANGE: OgmiosObservableCardanoNode and bufferChainSyncEvent were moved from core package to projection package
0244fe7
to
dd8b52f
Compare
Context
@cardano-sdk/core requires rxjs but it seems not having it in its dependencies
Proposed Solution
Hoist bufferChainSyncEvent (the only dependent on rxjs) to projection package