-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Trezor conway era certificates #1460
feat: add Trezor conway era certificates #1460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀 ! Just 1 question below
|
…onBody BREAKING CHANGE: keyAgent signTransaction now takes Serialization.TransactionBody instead of Core.TxBodyWithHash
fac6b73
to
82d372b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @AngelCastilloB !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 1 suggestion how we could simplify hasTaggedSets
below
packages/core/src/Serialization/TransactionBody/TransactionBody.ts
Outdated
Show resolved
Hide resolved
948366e
948366e
to
0fd55dc
Compare
…o use tagged CBOR sets
644c32c
Omit<Trezor.CardanoSignTransaction, 'signingMode' | 'derivationType' | 'includeNetworkId'>, | ||
Omit<Trezor.CardanoSignTransaction, 'signingMode' | 'derivationType' | 'includeNetworkId' | 'chunkify' | 'ttl'> & { | ||
/* eslint-disable @typescript-eslint/no-explicit-any */ | ||
ttl: any; // TODO: the Transformer util cant handle ttl as TOptional<string | number> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Context
We should update @trezor/connec and trezor/connect-web packages to the version 9.4 which supports Conway era.
Proposed Solution
Update packages and add new mappers for conway era certs