-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protected automated deployment to environments #1382
Open
ce0la
wants to merge
13
commits into
master
Choose a base branch
from
feat/automated-protected-deployments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
30db182
Add protected automated deployment to environments
ce0la cdd38e1
Refactor workflow
ce0la 47e88e0
Remove duplicate line
ce0la ebe9851
Set default env as string literal
ce0la 7718b0e
Fix empty env var
ce0la bca3bab
Update env var
ce0la 0e6b0ac
Update envrc source
ce0la 107788f
Check source
ce0la 1882421
Refactor deployment script
ce0la 66165df
Refactor deployment script
ce0la 6e81a8f
Fix string literals
ce0la 333908f
Update syntax for final PR review and remove redundant line
ce0la 7868c92
chore: update deployment environments
ce0la File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: Deploy Environment | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| environment: | ||
| description: 'Environment to deploy to' | ||
| type: choice | ||
| required: true | ||
| default: 'ops-preview-1' | ||
| options: | ||
| - live-sanchonet@eu-central-1@v2 | ||
| - live-mainnet@eu-central-1@v2 | ||
| - live-sanchonet@us-east-2@v1 | ||
| - dev-mainnet@us-east-1 | ||
| - live-mainnet@us-east-2@v2 | ||
| - live-sanchonet@us-east-2@v2 | ||
| - dev-preprod@us-east-1@v2 | ||
| - live-preprod@eu-central-1@v2 | ||
| - dev-preview@us-east-1 | ||
| - live-preprod@us-east-2@v2 | ||
| - ops-preprod-1@us-east-1 | ||
| - dev-sanchonet@us-east-1@v1 | ||
| - live-preview@eu-central-1@v2 | ||
| - ops-preview-1@us-east-1 | ||
| - dev-sanchonet@us-east-1@v2 | ||
| - live-preview@us-east-2@v2 | ||
| - staging-preprod@us-east-1@v2 | ||
|
|
||
| jobs: | ||
| deploy: | ||
| environment: ${{ inputs.environment }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: 📥 Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: 🧰 Setup Nix | ||
| uses: cachix/install-nix-action@v21 | ||
|
|
||
| - name: 🚀 Deploy | ||
| run: | | ||
| echo "${{ secrets.ENVRC }}" > .envrc.local | ||
| nix develop -L --command bash -c ' | ||
| set -euo pipefail | ||
| echo "yes" | nix run .#cardano-services.${{ inputs.environment }}.apply | ||
| ' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, but don't we have to build the images first? 🤔 Or at least make sure they're built and pushed to ECR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, it should not have
pushat the top and then it should be fine. We may encounter a race condition once in a while but that's probably not going to be even noticableThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I plan to take out
push:once the PR is tested and cleared for merging.Ref: #1382 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks. I remember I added a check in dapp-store once, to prevent such a race condition, but they use Git commits to tag images.