-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for cip 1854 #1317
Conversation
|
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
packages/web-extension/test/walletManager/WalletRepository.test.ts
Outdated
Show resolved
Hide resolved
19c238b
to
9b0525d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀 Please squash to minimal # of commits (seems like the 2 commits that @AngelCastilloB initially created is good)
9b0525d
to
0788606
Compare
Context
Key agent only supported CIP1852 which would make it impossible to create multi-sig keys complaint with CIP-1954
Proposed Solution
Add support for CIP 1854 to key agent and wallet repository.