Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shellcheck, shfmt and checkbashisms #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add shellcheck, shfmt and checkbashisms #62

wants to merge 2 commits into from

Conversation

bofhbug
Copy link

@bofhbug bofhbug commented Jul 21, 2021

add shellcheck, shfmt and checkbashisms
solves #25

maxbischoff
maxbischoff requested changes Sep 21, 2021
View reviewed changes
Copy link
Member

@maxbischoff maxbischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this and sorry for not looking at this earlier!
I have a minor request but otherwise LGTM :)

.github/workflows/sh-checker.yaml Outdated Show resolved Hide resolved
@maxbischoff maxbischoff self-requested a review November 9, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbischoff maxbischoff Awaiting requested review from maxbischoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bofhbug @maxbischoff