Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #800

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Maintenance #800

merged 3 commits into from
Jan 27, 2025

Conversation

velrest
Copy link
Contributor

@velrest velrest commented Jan 23, 2025

These dependencies cause problems, haven't looked into it yet:

 ○ dependencies
    ○ Package                                                    Current   Target            URL
    ○ @glimmer/component                                           1.1.2 ❯ 2.0.0
  ○ devDependencies
    ○ Package                                                    Current   Target            URL
    ○ ember-load-initializers                                      2.1.2 ❯ 3.0.1
    ○ ember-qunit                                                  8.1.0 ❯ 9.0.1
    ○ ember-resolver                                              12.0.1 ❯ 13.1.0

@velrest velrest changed the title chore(maintenance): update all deps in specified range Maintenance Jan 23, 2025
@velrest velrest marked this pull request as ready for review January 23, 2025 15:28
@velrest velrest requested a review from derrabauke January 23, 2025 15:28
@velrest
Copy link
Contributor Author

velrest commented Jan 23, 2025

Also sorry for the early ping @derrabauke because i only now remembered that this addon is completely untested.

@velrest
Copy link
Contributor Author

velrest commented Jan 23, 2025

Turns out we only have 8 tests:

tests/unit/services/languages-test.js
tests/unit/utils-test.js
tests/integration/helpers/build-url-test.js
tests/integration/helpers/current-quarter-test.js
tests/integration/components/search/filters-test.js
tests/integration/components/search/search-test.js
tests/integration/components/instance-link-test.js
tests/integration/components/search-street-test.js

I am sad

@velrest
Copy link
Contributor Author

velrest commented Jan 23, 2025

@derrabauke i started the app and everything seems to work. So if you have time please review.

Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that coverage is a shame 😭 -- but upgrade LGTM 👍

@velrest velrest merged commit b389277 into inosca:main Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants