[sock] flush / handle lines during input handling when a telnet SB (renegotation) is received #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enegotation) is received This is needed to properly keep GMCP/ATCP handling inline against the incoming socket data lines. Otherwise the SB attributes get handled first whilst the normal data is queued into the line buffer, and then the line buffer is handled at the end. I don't like doing the socket flush here though. Ugh.
|
Not sure how to test it but seems fine.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to properly keep GMCP/ATCP handling inline against the incoming socket data lines. Otherwise the SB attributes get handled first whilst the normal data is queued into the line buffer, and then the line buffer is handled at the end.
For issue #83