-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CI: move to language specific flows (#398)
Updates the CI to: - run per supported language - conditional run logic - pipelined jobs for failing fast - additional parallelization - run golang build on windows - reuse the check-changed-files workflow
- Loading branch information
1 parent
d900819
commit 1c1b2ba
Showing
12 changed files
with
317 additions
and
282 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: Check Changed Files | ||
|
||
on: | ||
workflow_call: | ||
outputs: | ||
golang: | ||
description: "Flag for if GoLang files changed" | ||
value: ${{ jobs.check-changed-files.outputs.golang }} | ||
rust: | ||
description: "Flag for if Rust files changed" | ||
value: ${{ jobs.check-changed-files.outputs.rust }} | ||
cpp_cuda: | ||
description: "Flag for if C++/CUDA files changed" | ||
value: ${{ jobs.check-changed-files.outputs.cpp_cuda }} | ||
|
||
jobs: | ||
check-changed-files: | ||
name: Check Changed Files | ||
runs-on: ubuntu-22.04 | ||
outputs: | ||
golang: ${{ steps.changed_files.outputs.golang }} | ||
rust: ${{ steps.changed_files.outputs.rust }} | ||
cpp_cuda: ${{ steps.changed_files.outputs.cpp_cuda }} | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v4 | ||
- name: Get all changed files | ||
id: changed-files-yaml | ||
uses: tj-actions/changed-files@v39 | ||
# https://github.com/tj-actions/changed-files#input_files_yaml_from_source_file | ||
with: | ||
files_yaml_from_source_file: .github/changed-files.yml | ||
- name: Run Changed Files script | ||
id: changed_files | ||
# https://github.com/tj-actions/changed-files#outputs- | ||
run: | | ||
echo "golang=${{ steps.changed-files-yaml.outputs.golang_any_modified }}" >> "$GITHUB_OUTPUT" | ||
echo "rust=${{ steps.changed-files-yaml.outputs.rust_any_modified }}" >> "$GITHUB_OUTPUT" | ||
echo "cpp_cuda=${{ steps.changed-files-yaml.outputs.cpp_any_modified }}" >> "$GITHUB_OUTPUT" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
name: C++/CUDA | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
- dev | ||
push: | ||
branches: | ||
- main | ||
- dev | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
check-changed-files: | ||
uses: ./.github/workflows/check-changed-files.yml | ||
|
||
check-format: | ||
name: Check Code Format | ||
runs-on: ubuntu-22.04 | ||
needs: check-changed-files | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Check clang-format | ||
if: needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
run: if [[ $(find ./ \( -path ./icicle/build -prune -o -path ./**/target -prune -o -path ./examples -prune \) -iname *.h -or -iname *.cuh -or -iname *.cu -or -iname *.c -or -iname *.cpp | xargs clang-format --dry-run -ferror-limit=1 -style=file 2>&1) ]]; then echo "Please run clang-format"; exit 1; fi | ||
|
||
test-linux: | ||
name: Test on Linux | ||
runs-on: [self-hosted, Linux, X64, icicle] | ||
needs: [check-changed-files, check-format] | ||
strategy: | ||
matrix: | ||
curve: [bn254, bls12_381, bls12_377, bw6_761] | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v4 | ||
- name: Build | ||
working-directory: ./icicle | ||
if: needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
run: | | ||
mkdir -p build | ||
cmake -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Release -DCURVE=${{ matrix.curve }} -DG2_DEFINED=ON -S . -B build | ||
cmake --build build | ||
- name: Run C++ Tests | ||
working-directory: ./icicle/build | ||
if: needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
run: ctest |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
name: GoLang | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
- dev | ||
push: | ||
branches: | ||
- main | ||
- dev | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
check-changed-files: | ||
uses: ./.github/workflows/check-changed-files.yml | ||
|
||
check-format: | ||
name: Check Code Format | ||
runs-on: ubuntu-22.04 | ||
needs: check-changed-files | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Check gofmt | ||
if: needs.check-changed-files.outputs.golang == 'true' | ||
run: if [[ $(go list ./... | xargs go fmt) ]]; then echo "Please run go fmt"; exit 1; fi | ||
|
||
build-linux: | ||
name: Build on Linux | ||
runs-on: [self-hosted, Linux, X64, icicle] | ||
needs: [check-changed-files, check-format] | ||
strategy: | ||
matrix: | ||
curve: [bn254, bls12_381, bls12_377, bw6_761] | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v4 | ||
- name: Build | ||
working-directory: ./wrappers/golang | ||
if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
run: ./build.sh ${{ matrix.curve }} ON # builds a single curve with G2 enabled | ||
- name: Upload ICICLE lib artifacts | ||
uses: actions/upload-artifact@v4 | ||
if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
with: | ||
name: icicle-builds-${{ matrix.curve }}-${{ github.workflow }}-${{ github.sha }} | ||
path: icicle/build/libingo_${{ matrix.curve }}.a | ||
retention-days: 1 | ||
|
||
test-linux: | ||
name: Test on Linux | ||
runs-on: [self-hosted, Linux, X64, icicle] | ||
needs: [check-changed-files, build-linux] | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v4 | ||
- name: Download ICICLE lib artifacts | ||
uses: actions/download-artifact@v4 | ||
if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
with: | ||
path: ./icicle/build/ | ||
merge-multiple: true | ||
- name: Run Tests | ||
working-directory: ./wrappers/golang | ||
if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
# -count ensures the test results are not cached | ||
# -p controls the number of programs that can be run in parallel | ||
run: | | ||
export CPATH=$CPATH:/usr/local/cuda/include | ||
go test --tags=g2 ./... -count=1 -failfast -p 2 -timeout 60m | ||
# TODO: bw6 on windows requires more memory than the standard runner has | ||
# Add a large runner and then enable this job | ||
# build-windows: | ||
# name: Build on Windows | ||
# runs-on: windows-2022 | ||
# needs: [check-changed-files, check-format] | ||
# strategy: | ||
# matrix: | ||
# curve: [bn254, bls12_381, bls12_377, bw6_761] | ||
# steps: | ||
# - name: Checkout Repo | ||
# uses: actions/checkout@v4 | ||
# - name: Download and Install Cuda | ||
# if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
# id: cuda-toolkit | ||
# uses: Jimver/[email protected] | ||
# with: | ||
# cuda: '12.0.0' | ||
# method: 'network' | ||
# # https://docs.nvidia.com/cuda/archive/12.0.0/cuda-installation-guide-microsoft-windows/index.html | ||
# sub-packages: '["cudart", "nvcc", "thrust", "visual_studio_integration"]' | ||
# - name: Build libs | ||
# if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true' | ||
# working-directory: ./wrappers/golang | ||
# env: | ||
# CUDA_PATH: ${{ steps.cuda-toolkit.outputs.CUDA_PATH }} | ||
# shell: pwsh | ||
# run: ./build.ps1 ${{ matrix.curve }} ON # builds a single curve with G2 enabled |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.