Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Get method on Connector Client for Teams specific context #74

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

pkosiec
Copy link
Contributor

@pkosiec pkosiec commented Oct 27, 2023

Hi,
First of all, awesome library! We were missing an ability to send authenticated requests for team details. That's why I implemented such functionality in the Connector Client.

This PR brings two improvements:

Let me know what you think!
Cheers!

Resolves #71

@pkosiec pkosiec changed the title Support Get method on Connector Client Support Get method on Connector Client for Teams bot context (team, channels, etc.) Oct 27, 2023
@pkosiec pkosiec changed the title Support Get method on Connector Client for Teams bot context (team, channels, etc.) Support Get method on Connector Client for Teams specific context Oct 27, 2023
Copy link
Member

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pkosiec. Have some minor questions.

connector/client/client.go Outdated Show resolved Hide resolved
connector/client/client.go Show resolved Hide resolved
Copy link
Contributor Author

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PrasadG193 for your comments! I responded to them - please see the answers. Once everything will be clear I'll push the fixes. Thank you! 🙏

connector/client/client.go Outdated Show resolved Hide resolved
connector/client/client.go Show resolved Hide resolved
Copy link
Member

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@pkosiec
Copy link
Contributor Author

pkosiec commented Nov 24, 2023

Hey @PrasadG193, looks like the Travis is not executed. Should I try to force create a new commit (git commit --amend --no-edit && git commit push -f), or is it a problem with the pipeline itself?

@PrasadG193 PrasadG193 enabled auto-merge (squash) November 30, 2023 06:16
@PrasadG193 PrasadG193 enabled auto-merge (squash) November 30, 2023 06:42
@PrasadG193
Copy link
Member

@pkosiec could you please rebase the PR? I am not sure why the build action is not getting triggered, could be because its waiting on push event

@pkosiec
Copy link
Contributor Author

pkosiec commented Nov 30, 2023

Sure, will do that in 1-2 hours 👍

@pkosiec
Copy link
Contributor Author

pkosiec commented Nov 30, 2023

@PrasadG193 done 👍

@PrasadG193 PrasadG193 enabled auto-merge (squash) November 30, 2023 08:51
@PrasadG193 PrasadG193 merged commit 84d2040 into infracloudio:develop Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello everyone, please how do I get the user's email?
2 participants