-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Get method on Connector Client for Teams specific context #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @pkosiec. Have some minor questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PrasadG193 for your comments! I responded to them - please see the answers. Once everything will be clear I'll push the fixes. Thank you! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR
Hey @PrasadG193, looks like the Travis is not executed. Should I try to force create a new commit ( |
@pkosiec could you please rebase the PR? I am not sure why the build action is not getting triggered, could be because its waiting on push event |
Sure, will do that in 1-2 hours 👍 |
@PrasadG193 done 👍 |
Hi,
First of all, awesome library! We were missing an ability to send authenticated requests for team details. That's why I implemented such functionality in the Connector Client.
This PR brings two improvements:
Get
method for Connector Client (to get channels, team details, etc.)activity
for the ClientDelete
methodLet me know what you think!
Cheers!
Resolves #71