Add GetSenderInfo function to get message sender info #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risboo6909
force-pushed
the
get_member_info
branch
from
ef763dc
to
7de01c1
Compare
PrasadG193
reviewed
Jul 22, 2021
There was a problem hiding this comment.
@risboo6909, thanks for the PR. Do you mind adding a sample/example under sample dir?
Comment on lines
+76
to
+91
| req.Header.Set("Content-Type", "application/json") | ||
| req.Header.Set("Authorization", "Bearer "+token) | ||
|
|
||
| httpClient := &http.Client{} | ||
| resp, err := httpClient.Do(req) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| body, err := ioutil.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return body, nil |
There was a problem hiding this comment.
can we use client.sendRequest() method to avoid duplicate code?
Comment on lines
+99
to
+101
|
|
||
| return resp, nil | ||
|
|
There was a problem hiding this comment.
Suggested change
| return resp, nil | |
| return resp, nil |
[nit] unnecessary new lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I missed the feature to get an email address of the user sending message to my bot.
Opening PR, because this feature may be helpful for other people.
Usage pattern is like this (I omitted errors handling for simplicity):
senderInfowill contain user info (including email address, id, name, etc).