feat(relayer): implement poseidon hash #186
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbguy
commented
Jan 11, 2025
Comment on lines
+123
to
+128
| // let mut trace_path_span = self.trace_path.span(); | ||
| // while let Option::Some(path) = trace_path_span.pop_front() { | ||
| // key_builder.append_serde(path); | ||
| // }; | ||
| // key_builder.append_serde(self.base); | ||
| key_builder.append_serde(self); |
There was a problem hiding this comment.
I am not sure why PrefixedDenom was hashed manually when it implements Serde already.
Is this necessary? If yes, I am fine to revert this and make it compatible at relayer e2e side.
rnbguy
commented
Jan 11, 2025
Comment on lines
423
to
425
| let ibc_prefixed_denom_key = PoseidonState::digest(&[PoseidonState::digest( | ||
| &cairo_encoding.encode(&ibc_prefixed_denom)?, | ||
| )]); |
There was a problem hiding this comment.
The .key() method in Cairo uses,
I am not sure why the double hashing is necessary. Why can't we use the following?
poseidon_hash_span(self.data.span())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175
Closes #180
starknet-integration-tests