Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use memmap2 instead of memmap, enable rustls on windows, fix typos in openssl api #206

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - Use memmap2 instead of memmap, enable rustls on windows, fix typos in openssl api #206

wants to merge 20 commits into from

Conversation

ozgrakkurt
Copy link
Contributor

@ozgrakkurt ozgrakkurt commented Apr 18, 2023 •
edited by bors bot
Loading

No description provided.

sehz
sehz approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump up crate version (patch)

@ozgrakkurt
Copy link
Contributor Author

bump up crate version (patch)

done

@morenol
Copy link
Contributor

morenol commented Apr 18, 2023

Maybe it will fail to compail due to:

future-aio/src/rust_tls.rs

Line 107 in e97957e

use std::os::unix::io::AsRawFd;
?

@ozgrakkurt
Copy link
Contributor Author

Maybe it will fail to compail due to:

future-aio/src/rust_tls.rs

Line 107 in e97957e

use std::os::unix::io::AsRawFd;

?

Maybe I fixed it?

@ozgrakkurt
Copy link
Contributor Author

probably should add windows to CI, doing it now

@ozgrakkurt ozgrakkurt requested a review from morenol April 18, 2023 18:15
morenol
morenol reviewed Apr 18, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ozgrakkurt
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@ozgrakkurt
enable rustls on windows (#206)
e5418e6
@bors
Copy link

bors bot commented Apr 18, 2023

Build failed:

@ozgrakkurt ozgrakkurt changed the title enable rustls on windows Use memmap2 instead of memmap, enable rustls on windows Apr 18, 2023
@ozgrakkurt
Copy link
Contributor Author

closes #207

@morenol
Copy link
Contributor

morenol commented Apr 18, 2023

@sehz could you check that dependency update?

@ozgrakkurt
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@ozgrakkurt
Use memmap2 instead of memmap, enable rustls on windows (#206)
caaf948
@sehz sehz mentioned this pull request Apr 18, 2023
Open
@bors
Copy link

bors bot commented Apr 18, 2023

Canceled.

@ozgrakkurt
Copy link
Contributor Author

closes #175

@ozgrakkurt ozgrakkurt changed the title Use memmap2 instead of memmap, enable rustls on windows Use memmap2 instead of memmap, enable rustls on windows, fix typos in openssl api Apr 18, 2023
@ozgrakkurt
Copy link
Contributor Author

closes #108

@ozgrakkurt
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@ozgrakkurt
Use memmap2 instead of memmap, enable rustls on windows, fix typo…
b46911c 
…s in openssl api (#206)
@ozgrakkurt
Copy link
Contributor Author

bors cancel

@bors
Copy link

bors bot commented Apr 18, 2023

Canceled.

@ozgrakkurt
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@ozgrakkurt
Use memmap2 instead of memmap, enable rustls on windows, fix typo…
82063ce 
…s in openssl api (#206)
@bors
Copy link

bors bot commented Apr 18, 2023

Build failed:

@ozgrakkurt
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@ozgrakkurt
Use memmap2 instead of memmap, enable rustls on windows, fix typo…
5ed868d 
…s in openssl api (#206)
@bors
Copy link

bors bot commented Apr 18, 2023

Canceled.

@ozgrakkurt
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@ozgrakkurt
Use memmap2 instead of memmap, enable rustls on windows, fix typo…
6c7c44b 
…s in openssl api (#206)
@bors
Copy link

bors bot commented Apr 18, 2023

Pull request successfully merged into master.

Build succeeded:

  • Done

@bors bors bot changed the title Use memmap2 instead of memmap, enable rustls on windows, fix typos in openssl api [Merged by Bors] - Use memmap2 instead of memmap, enable rustls on windows, fix typos in openssl api Apr 18, 2023
@bors bors bot closed this Apr 18, 2023
@bors bors bot deleted the windows-rustls branch April 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morenol morenol morenol approved these changes

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozgrakkurt @morenol @sehz