Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: ConsumerConfigExt #511

Merged
merged 2 commits into from
Nov 13, 2024
Merged

add: ConsumerConfigExt #511

merged 2 commits into from
Nov 13, 2024

Conversation

digikata
Copy link
Contributor

@digikata digikata commented Nov 12, 2024

  • also adds ConsumerConfigExtBuilder, with
  • add consume tests and refactor more
  • add config access to disable_continuous for disconnect after fetch
    (see test_consume.py)
  • fix remove unnecessary layer to Offset struct

@digikata
Copy link
Contributor Author

Addresses #512

Offset management is a known further issue to work on, but offset start specifications and ConsumeConfigExtBuilder::disable_continuous work (for fetch and disconnect)

- add consume tests and refactor more
- add config access to disable_continuous for disconnect after fetch
  (see test_consume.py)
- fix remove unecessary layer to Offset struct
@digikata digikata force-pushed the ac/add-consume-config-ext branch 2 times, most recently from dfe23b7 to aa62545 Compare November 12, 2024 20:31
@digikata digikata marked this pull request as draft November 12, 2024 20:53
@digikata
Copy link
Contributor Author

digikata commented Nov 13, 2024

Fixing up docs and refactoring more

@digikata digikata marked this pull request as ready for review November 13, 2024 16:54
- lint and format code
- cleanup docs generation, pickup lib.rs module code by using __any__
@digikata digikata merged commit 03d9b42 into main Nov 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant