noNA conflict of assertthat
and terra
#110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assertthat::noNA
check used in assertions might be masked by theterra::noNA
function.In those cases, the not-too-instructive error message is thrown:
This happened to me when using modules of the
watina
package in a non-RStudio context; I think theroxygen::@importFrom
requirements prevent the error, for the majority of users. (I cannot tell whether those implicit imports run correctly in debugging contexts.)However, combined use of
terra
andwatina
is quite common, we can not ensure IDE 100%, and the change is minor effort, so I would argue for an explicit call ofassertthat::noNA
.The suggested change is nothing more than that: all
noNA
calls are replaced byassertthat::noNA
.Note: this is supposed to merge into
dev_nextrelease
, I hope I did it right with the PR.