Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmrunge/schedules #48

Merged
merged 9 commits into from
Mar 18, 2014
Merged

Jmrunge/schedules #48

merged 9 commits into from
Mar 18, 2014

Conversation

jmrunge
Copy link
Member

@jmrunge jmrunge commented Mar 10, 2014

Replaces #19
Depends on inaes-tic/mbc-common#66

jmrunge added 2 commits March 10, 2014 11:04
Signed-off-by: Juan Martin Runge <[email protected]>
Signed-off-by: Juan Martin Runge <[email protected]>
@jmrunge jmrunge mentioned this pull request Mar 10, 2014
if (!opts.ignore)
self.removeSched.bind(self)(sched);
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fetching all scheds from DB?
You have to use custom mongo queries over bb collections like in playout view.
Collection must use searchWrapper.

this.collection.fetch({
    success: function() {
    },
    error: function(e) {
    },
    data: {
        query: {criteria: {in_window: [start.valueOf(), end.valueOf()]}},
    },
});

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Will do it and let you know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now is necessary to fetch all schedules because we dont have a tick on scheduler to refetch like mosto does. I was planning to do it on a next PR to keep this one smaller. Is this ok with you or should I add this feature now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but add an issue for this feature, so we can remember it later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! #53

@josx
Copy link
Member

josx commented Mar 12, 2014

I dont understand very well, how it is working? @jmrunge can you explain it?

@jmrunge
Copy link
Member Author

jmrunge commented Mar 13, 2014

@josx
Its quite simple: You select a sketch in the sketchs combo box and click on the "Schedule" button. This opens a prompt for you to write date (dd/MM/yyyy HH:mm:ss format, validation and perhaps a date time picker are pending) and a duration (its in seconds and can be null) and you generate a schedule.
Etiquette is listening for schedules and at the moment it receives one, it sets a timeout for it to be loaded and (if durations was specified) a timeout to unload it. On unload, schedules are deleted from DB.
Obviously etiquette reads all schedules at start of the application to process them.
There is also a combo box on the editor where you can choose a schedule and delete it. Apart from deleting it from the DB it also cancels timeouts for load and unload if they exist and unload the sketch if its loaded.
Hope it was clear enough, feel free to ask for more details if not.

@lvidarte
Copy link
Contributor

@jmrunge would be nice, at least for now, to put the datetime format "dd/mm/yyyy hh:mm:ss" in the prompt dialog

@jmrunge
Copy link
Member Author

jmrunge commented Mar 13, 2014

Ooops, was sure it was! Checked and there wasnt! Will do it...

2014-03-13 11:06 GMT-03:00 Leo Vidarte [email protected]:

@jmrunge https://github.com/jmrunge would be nice, at least for now, to
put the date format "dd/mm/yyyy hh:mm:ss" in the prompt dialog

Reply to this email directly or view it on GitHubhttps://github.com//pull/48#issuecomment-37536269
.

@jmrunge
Copy link
Member Author

jmrunge commented Mar 17, 2014

Prompt dialog fixed

jmrunge added 2 commits March 17, 2014 10:27
Signed-off-by: Juan Martin Runge <[email protected]>
Signed-off-by: Juan Martin Runge <[email protected]>
josx added 2 commits March 18, 2014 11:06
Signed-off-by: José Luis Di Biase <[email protected]>
Signed-off-by: José Luis Di Biase <[email protected]>
josx added a commit that referenced this pull request Mar 18, 2014
@josx josx merged commit f1f8bb9 into master Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants