Fix range filter bug on paging, don't sort on values #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only ignore a key if all it's data is empty. In the case of range filter, we need to know which value we are filtering on (the greater than or less than) and it is fine if one of those values is Falsy
lefcourn
reviewed
Oct 26, 2018
seeker/views.py
Outdated
| parts.extend(urlencode({key: val}) for val in values) | ||
| return '&'.join(parts) | ||
| pass |
lefcourn
reviewed
Oct 29, 2018
seeker/views.py
Outdated
| @@ -315,14 +315,11 @@ def normalized_querystring(self, qs=None, ignore=None): | |||
| for key in sorted(data): | |||
| if ignore and key in ignore: | |||
| continue | |||
| if not data[key]: | |||
| if not data.getlist(key) or not any(data.getlist(key)): | |||
There was a problem hiding this comment.
Can we put "values = data.getlist(key)" above this and just do the "any" check?
… list Since all items passed in are string values, the only false items would be an empty values list or a a list of empty strings.
|
Did you mean for this to go into master, or 4.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only ignore a key if all it's data is empty. In the case of range
filter, we need to know which value we are filtering on (the greater
than or less than) and it is fine if one of those values is Falsy