Standardize date range facet placeholders #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salsburj
reviewed
Jun 12, 2024
| @@ -66,6 +66,7 @@ def __init__(self, field, label=None, sort=None, value_format=None, template=Non | |||
| self.export = export | |||
| self.highlight = highlight | |||
| self.field_definition = field_definition | |||
| self.sr_class = 'sr-only' | |||
There was a problem hiding this comment.
sr-only is for Bootstrap 4. visually-hidden is for Bootstrap 5.
That said, I'm not sure how seeker should handle Bootstrap constructs. Bootstrap is not a dependency, though we do link to a Bootstrap 3 CDN in the seeker.html template.
There was a problem hiding this comment.
Damn I totally messed up the syncing of my forked repo. These changes aren't supposed to be in this PR. These were supposed to be part of: #160, where we wanted to make this both bootstrap 4 and 5 compatible by adding hooks. I don't think we need this PR to standardize date range format anymore, since I found a more viable solution in Bioshare itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize capitalization on seeker date range facets.