Don't filter out duplicate fac/phys (#49)

imsweb · Sep 22, 2023 · f13784b · f13784b
1 parent 019db3b
commit f13784b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/src/main/java/com/imsweb/datagenerator/provider/facility/FacilityDataGenerator.java b/src/main/java/com/imsweb/datagenerator/provider/facility/FacilityDataGenerator.java
@@ -30,7 +30,6 @@ public String getId() {
      * @return generated FacilityFrequencyDto
      */
     private FacilityFrequencyDto generateFacility(ProviderDataGeneratorOptions options) {
-        // make sure options are never null
         if (options == null)
             options = new ProviderDataGeneratorOptions();
 
@@ -48,16 +47,12 @@ private FacilityFrequencyDto generateFacility(ProviderDataGeneratorOptions optio
      * @return list of generated facilities
      */
     public List<FacilityFrequencyDto> generateFacilities(int numProviders, ProviderDataGeneratorOptions options) {
-        // make sure options are never null
         if (options == null)
             options = new ProviderDataGeneratorOptions();
 
         List<FacilityFrequencyDto> facilities = new ArrayList<>();
-        for (int i = 0; i < numProviders; i++) {
-            FacilityFrequencyDto facility = generateFacility(options);
-            if (!facilities.contains(facility))
-                facilities.add(facility);
-        }
+        for (int i = 0; i < numProviders; i++)
+            facilities.add(generateFacility(options));
 
         return facilities;
     }

diff --git a/src/main/java/com/imsweb/datagenerator/provider/physician/PhysicianDataGenerator.java b/src/main/java/com/imsweb/datagenerator/provider/physician/PhysicianDataGenerator.java
@@ -30,7 +30,6 @@ public String getId() {
      * @return generated PhysicianFrequencyDto
      */
     private PhysicianFrequencyDto generatePhysician(ProviderDataGeneratorOptions options) {
-        // make sure options are never null
         if (options == null)
             options = new ProviderDataGeneratorOptions();
 
@@ -48,16 +47,12 @@ private PhysicianFrequencyDto generatePhysician(ProviderDataGeneratorOptions opt
      * @return list of generated physicians
      */
     public List<PhysicianFrequencyDto> generatePhysicians(int numProviders, ProviderDataGeneratorOptions options) {
-        // make sure options are never null
         if (options == null)
             options = new ProviderDataGeneratorOptions();
 
         List<PhysicianFrequencyDto> physicians = new ArrayList<>();
-        for (int i = 0; i < numProviders; i++) {
-            PhysicianFrequencyDto physician = generatePhysician(options);
-            if (!physicians.contains(physician))
-                physicians.add(physician);
-        }
+        for (int i = 0; i < numProviders; i++)
+            physicians.add(generatePhysician(options));
 
         return physicians;
     }