refactor: add description parameter

impress-org · Aug 30, 2024 · bee429a · bee429a
1 parent d56d3ac
commit bee429a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/OffSiteGateway/Gateway/OffSiteCheckoutPageSimulation.php b/src/OffSiteGateway/Gateway/OffSiteCheckoutPageSimulation.php
@@ -66,8 +66,12 @@ private function loadOffSiteGatewaySimulationMarkup()
         <div class="container">
             <h1>Off-site Checkout Page Simulation</h1>
             <p>
-                Donation amount:<strong><?php
-                    echo isset($_GET['amount']) ? $_GET['amount']['currency'] . ' ' . $_GET['amount']['value'] : 0; ?></strong>
+                Donation amount: <strong><?php
+                    echo isset($_GET['amount']) ? $_GET['amount']['currency'] . ' ' . $_GET['amount']['value'] : ' 0'; ?></strong>
+            </p>
+            <p>
+                Description: <strong><?php
+                    echo $_GET['description'] ?? ' -'; ?></strong>
             </p>
             <hr />
             <p>

diff --git a/src/OffSiteGateway/Gateway/OffSiteGateway.php b/src/OffSiteGateway/Gateway/OffSiteGateway.php
@@ -126,12 +126,15 @@ public function createPayment(Donation $donation, $gatewayData): RedirectOffsite
             $donation->gatewayTransactionId = $payment->id;
             $donation->save();
 
+            /**
+             * This is necessary to make the off-site checkout page simulation work;
+             * In real-world integrations, this parameter isn't necessary.
+             */
             $paymentParameters['off-site-gateway-simulation'] = true;
 
             $redirectUrl = add_query_arg($paymentParameters, home_url());
 
             return new RedirectOffsite($redirectUrl);
-            //return new RedirectOffsite(add_query_arg('off-site-gateway-simulation', true, home_url()));
         } catch (Exception $e) {
             $donation->status = DonationStatus::FAILED();
             $donation->save();
@@ -165,7 +168,7 @@ public function getPaymentParameters(Donation $donation, $gatewayData): array
                 'value' => $donation->amount->formatToDecimal(),
                 'currency' => $donation->amount->getCurrency()->getCode(),
             ],
-            //'description' => MollieApi::getPaymentDescription($donation),
+            'description' => $donation->formTitle,
             'returnUrl' => $this->getPaymentsReturnURL($donation, $gatewayData),
             'cancelUrl' => $this->getPaymentsCancelURL($donation, $gatewayData),
             'webhookUrl' => $this->getPaymentsWebhookUrl($donation),