-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract City/State/Country from IPTC tags #15344
base: main
Are you sure you want to change the base?
feat: extract City/State/Country from IPTC tags #15344
Conversation
📖 Documentation deployed to pr-15344.preview.immich.app |
Hello, can you please help fix the failed tests? |
Lovely stuff! Did you look at writing this data into sidecars when Immich does reverse geocoding as well? No worries if not. |
Just I'm not sure why they broke. From the logs I only see
|
no, sorry, not sure on the concepts of sidecars, this whole stuff is quite new to me |
Ok so I guess one of the issues is that the e2e test asset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR enables extracting Locality information (City/State/Country) from exif IPTC tags instead of relying on reverse geocoding.
This also skips reverse geocoding if any of those tags are set and just uses their values.
Why this change? I have bunch of photos from Alps where there are no bigger cities nearby, so Immich fails to reverse geocode the location, so I've set them directly into the photos by using Google Places API and now want to upload and display them in Immich. Reasoning behind this change and more info can be found in this discussion #15270
To set those tags on an JPG you can use exiftool, e.g.:
Which then can be viewed in any image editor:
And which is extracted once uploaded to Immich:
Things I'm not sure about:
StringOrNumber
(assumed those are as Description tags)Any feedback welcome.