Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgproxy_pro_active_storage route #6

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

DarthSim
Copy link
Member

@DarthSim DarthSim commented Dec 22, 2023

What is the purpose of this pull request?

imgproxy Pro can generate previews for videos and PDFs. imgproxy Pro does it faster and provides more flexibility than ActiveStorage.

What changes did you make? (overview)

This PR adds checks for video/* and application/pdf content types. It also adds instructions on how to make videos and PDFs content types variable.

Checklist

  • I've added tests for this change
  • I've added a Changelog entry
  • I've updated a documentation

@DarthSim DarthSim force-pushed the feature/imgproxy_pro_active_storage branch from b926c38 to 131c899 Compare December 22, 2023 16:37
@DarthSim DarthSim marked this pull request as draft December 22, 2023 16:57
@DarthSim DarthSim force-pushed the feature/imgproxy_pro_active_storage branch from 131c899 to b5137e7 Compare December 22, 2023 17:13
@DarthSim DarthSim requested a review from Bakaface December 22, 2023 17:18
@DarthSim DarthSim marked this pull request as ready for review December 22, 2023 17:19
spec/internal_spec.rb Show resolved Hide resolved
@DarthSim DarthSim merged commit bc0eafb into master Dec 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants