Add support for showing BTC and USD (or local) currency prices. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sondreb
commented
Jan 18, 2019
sondreb
commented
- Adds support for showing both BTC and USD.
- Depending on the API used to get prices, the USD price might come from API, or might be calculated based on BTC rate.
- If price is available in USD, then the actual BTC price is derived from USD of the coin.
- Changes from double to decimal types for money-related objects.
… by release pipeline. - Move custom style to extra .css to ensure update/refresh in deployment.
- Replace the unicode BTC character with the one from Font Awesome. - Add support for customize the top header logo.
- Temporary URL until gitbook editing is completed.
|
@sondreb it's good, can I merge ? |
|
Yes, please merge if you can :-) |
|
Yes, do you know why the build failed ? |
- Disk space will eventually run out, user must then manually expand both on Azure, and the partition within the Linux OS.
- Needs a specified private IP address.
- Upgrade Ubuntu from 16 to 18.
- Was linking to wrong repo, fixed by updating the URLs.
imclint21
approved these changes
Oct 2, 2019
| @@ -1,9 +1,9 @@ | |||
| # Stratis.Guru Documentation | |||
| # City Chain Explorer Documentation | |||
There was a problem hiding this comment.
Is it multichain or citychain Oo
|
Said me when I need to merge |
- The stats now returns HTML if no query version is supplied, this made the block explorer crash as it was looking for a JSON result.
- Adds a custom tag helper to display coin, making it possible to individually style it.
- Nako URL must end with /
- The status value has changed first letter capitalization in the Nako API, and the explorer was using dynamic object type. Entity model for status has been added. - Remove third party scripts, not needed and avoid tracking. - Fix a bug with red/green on coin movement on an address. - Add additional properties on the block details.
- More details for transactions with improved input/output section. - Removed some links that was not needed. - Reverted previous color change for in/out for coins.
- The hero graphics was PNG and almost half a MB in size. - Changed the image type to JPG, reducing file size to only 35KB.
- Fix the link, was going to .png and not new .jpg. - Re-saved the png into jpg with a tiny bit higher quality.
- Add version in path to CSS files.
- Return an empty Ticker instance when failing. - Adds logging of exception when ticker is not retrieved.
- Improve error handling on the CoinTagHelper, it does throw exception from time to time.
- Perhaps this should not be linked at all, as the user is already looking at the block and link goes to itself, but at least this will no longer give 404 messages.
- When there is no value for the parameter option, the generated links are invalid. Adds check for value and outputs different markup when there is no value to link to.
- Adds error handling and logging to the API. - Improve the documentation, updating URLs and examples to be correct.
Update URLs to use sub-domain (www) due to recent updated with the certificate generation not supporting bare-domains.
- The Block Explorer did not show decimal correctly for Norwegian culture, this should fix it for all different cultures.
- Add XDS to the explorer. - Missing details such as website, needs to be added later. Reusing the City Coin icon until another is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.