This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
Fix build problems on fresh checkout #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `vscode.d.ts` file is not installed by the `postinstall` script of the `vscode` package anymore. It is now contained in `@types/vscode` on NPM. See https://code.visualstudio.com/updates/v1_36#_splitting-vscode-package-into-typesvscode-and-vscodetest
The `imba build` command referenced in the `build` script does not work. What actually needs to be built seem to be the `client/dist/src/index.js` and `server/dist/src/index.js` files. This change builds these files explicitly.
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension does not build from a fresh checkout on my Debian in WSL2q, due to two problems:
The
vscodepackage is obsolete, and the postinstall script referenced inclient/package.jsondoes not exist anymore.See https://code.visualstudio.com/updates/v1_36#_splitting-vscode-package-into-typesvscode-and-vscodetest
The typings are now provided by
@types/vscode, so it is also unnecessary.This PR simply takes it out.
npm run buildcallsimba buildwhich complains that no script file is given to build.This PR changes the build process so that the two child projects are built one-by-one and explicitly.
I have no experience with the code base, and with imba, so there may be a better way to achieve a working build on my machine, but these two changes worked so I could build a functioning VSIX by
npm dev:bootstrap npm run build vsce package code --install-extension ./vsimba-*.vsixStill to do:
Development.mdto give all necessary build steps to build a working package