Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix section with zero problems in PieChart #1753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix section with zero problems in PieChart #1753

wants to merge 1 commit into from

Conversation

aimawari
Copy link

@aimawari aimawari commented Sep 23, 2024 •
edited
Loading

Summary

This pull request addresses issues related to #697, #817 and #1632.

Changes Made

  • Removed the filter that excluded sections with a value of 0 in PieChartData.
  • Ensured that calculateSectionsAngle does not return NaN values.
  • Skipped the rendering of sections with a value of 0.
  • Created a custom badgeWidgetPaint function to skip the rendering of the badgeWidget for sections with a value of 0.

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 20, 2024

Good job, please update the branch and conflicts. Please do this carefully (as it is related to this topic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aimawari @imaNNeo