Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gradient to FlLine #1446

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

Dartek12
Copy link
Contributor

@Dartek12 Dartek12 commented Sep 24, 2023

Adds a gradient option to the FlLine.

Example usage of gradient for horizontal line:
obraz

Issue: #1197

@imaNNeo
Copy link
Owner

imaNNeo commented Sep 30, 2023

Everything seems great! Thanks for contributing

There is just one thing to do, can you please update the current documentation in the base_chart.md?

After that, we're ready to merge!

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #1446 (95c18f4) into master (79e6ec7) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   86.54%   86.62%   +0.08%     
==========================================
  Files          45       45              
  Lines        2996     3014      +18     
==========================================
+ Hits         2593     2611      +18     
  Misses        403      403              
Files Coverage Δ
.../src/chart/base/axis_chart/axis_chart_painter.dart 73.75% <100.00%> (+0.98%) ⬆️
lib/src/chart/line_chart/line_chart_painter.dart 92.05% <100.00%> (+0.10%) ⬆️
lib/src/extensions/paint_extension.dart 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Dartek12
Copy link
Contributor Author

Dartek12 commented Oct 1, 2023

I have updated the documentation as requested

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 7, 2023

Can you please rebase your branch?

@Dartek12
Copy link
Contributor Author

Dartek12 commented Oct 7, 2023

@imaNNeo rebased as requested

@imaNNeo imaNNeo merged commit 696bb2d into imaNNeo:master Nov 5, 2023
4 checks passed
@imaNNeo
Copy link
Owner

imaNNeo commented Nov 5, 2023

Thanks for contributing!

@Dartek12 Dartek12 deleted the issue-1197-gradient-fl-line branch November 5, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants