Upgrade to Moodle 4.4 and addition of test coverage. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
MOODLE_404_STABLE
branch
6 times, most recently
from
f35af3f to
9b44e05
Compare
…uctors during sync. fixes ilios#52
corrects closing of the users loop.
…nstructor_sync prevents learner enrolment on instructor sync if no instructors could be found.
…tor_groups_during_instructor_sync check offering instructor groups before falling back to default instructors during sync.
increment version to indicate a patch release.
stopfstedt
force-pushed
the
MOODLE_404_STABLE
branch
2 times, most recently
from
2d8b56f to
c94f09f
Compare
copy/pasted from tool_ilioscategoryassigment.
the functionality we got from this dependency has been absorbed into this plugin. fixes typo in release info and bumps version while at it.
i'm dropping the year info from the copyright. it's unnecessary. this code has always, and will always, "belong to" the regents.
see ilios#50 this addresses the regression outline in
cleanup of test vectors while at it.
stopfstedt
force-pushed
the
MOODLE_404_STABLE
branch
from
c94f09f to
c07d8ec
Compare
fixes unrelated linting errors while at it.
do some cleanup on pre-existing tests while at it.
stopfstedt
force-pushed
the
MOODLE_404_STABLE
branch
from
4616196 to
3a2e6f1
Compare
these tests cover areas of the process that haven't changed during this refactor, but that should be covered with tests nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive refactoring - this replaces the shared API client sub-component with a custom-tailored, in-plugin replacement.
Lots of code got shuffled around to provide a cleaner separation of concerns and improved testability.