Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace resolved numpy workaround with dask workaround #245

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Nov 11, 2024

This is a twin of iiasa/message_ix#887, fixing the CI test suite by pinning dask until genno is compatible with the latest versions of it.

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update CI tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update doc/whatsnew. Just CI.

@glatterf42 glatterf42 added the ci Continuous integration & testing label Nov 11, 2024
@glatterf42 glatterf42 self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (0645fd5) to head (a71d060).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #245     +/-   ##
=======================================
- Coverage   76.5%   75.5%   -1.0%     
=======================================
  Files        203     203             
  Lines      15546   15546             
=======================================
- Hits       11896   11748    -148     
- Misses      3650    3798    +148     
Files with missing lines Coverage Δ
message_ix_models/model/water/data/demands.py 78.4% <100.0%> (ø)

... and 7 files with indirect coverage changes

@khaeru
Copy link
Member

khaeru commented Nov 11, 2024

@glatterf42 any idea why we're seeing two instances of each of the Codecov checks?

@glatterf42
Copy link
Member Author

Not really. I think I did a git commit --fixup and rebase locally while the tests started running and force pushed it immediately, so maybe that confused the GitHub runners. If that's the case, we should not see it anymore :)

@glatterf42 glatterf42 merged commit 6032244 into main Nov 12, 2024
26 checks passed
@glatterf42 glatterf42 deleted the fix/CI-dask-numpy branch November 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration & testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants